Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freshen crate, fix to/from_base64 #30

Closed
wants to merge 7 commits into from
Closed

Freshen crate, fix to/from_base64 #30

wants to merge 7 commits into from

Conversation

Jake-Shadle
Copy link

@Jake-Shadle Jake-Shadle commented Sep 10, 2019 •
edited
Loading

This change went further than initially expected, feel free to ask me to split it up into smaller PRs if you want!

  • FIX: Bitvec's to_bytes pads bits to the next byte, the test wasn't catching that this was a problem because the number of bits for the hash were divisible by 8, this just adds the number of padding bits into the top bits of the header byte that was being used for the HasherType so that the bitvec has the correct length after deserialization.
  • Add support for the latest version of image (0.22.2) - Fairly minor update
  • Bump rand to 0.7.0 - Only used by tests, so figured this was fine
  • Rustformatted and fixed all the clippy lints

@Jake-Shadle Jake-Shadle mentioned this pull request Sep 10, 2019
Open
26 tasks
@repi repi mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jake-Shadle